net/mlx5: Fix driver use of uninitialized timeout

Browse source

[ Upstream commit 42b4f7f66a ]

Currently, driver is setting default values to all timeouts during
function setup. The offending commit is using a timeout before
function setup, meaning: the timeout is 0 (or garbage), since no
value have been set.
This may result in failure to probe the driver:
mlx5_function_setup:1034:(pid 69850): Firmware over 4294967296 MS in pre-initializing state, aborting
probe_one:1591:(pid 69850): mlx5_init_one failed with error code -16

Hence, set default values to timeouts during tout_init()

Fixes: 37ca95e62e ("net/mlx5: Increase FW pre-init timeout for health recovery")
Signed-off-by: Shay Drory <shayd@nvidia.com>
Reviewed-by: Moshe Shemesh <moshe@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

...

This commit is contained in:

Shay Drory 2022-06-27 16:05:31 +03:00 • committed by Greg Kroah-Hartman

parent 5097042888

commit e43f83cea9

3 changed files with 4 additions and 10 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

11

drivers/net/ethernet/mellanox/mlx5/core/lib/tout.c

View file

1

drivers/net/ethernet/mellanox/mlx5/core/lib/tout.h

View file

2

drivers/net/ethernet/mellanox/mlx5/core/main.c

View file