ALSA: emu10k1: Fix card shortname string buffer overflow

Browse source

commit d02260824e upstream.

Some models provide too long string for the shortname that has 32bytes
including the terminator, and it results in a non-terminated string
exposed to the user-space.  This isn't too critical, though, as the
string is stopped at the succeeding longname string.

This patch fixes such entries by dropping "SB" prefix (it's enough to
fit within 32 bytes, so far).  Meanwhile, it also changes strcpy()
with strlcpy() to make sure that this kind of problem won't happen in
future, too.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>

...

This commit is contained in:

Takashi Iwai 2015-04-27 13:00:09 +02:00 • committed by Luis Henriques

parent a92a43a16c

commit e45af6c86a

2 changed files with 6 additions and 4 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

sound/pci/emu10k1/emu10k1.c

View file

4

sound/pci/emu10k1/emu10k1_main.c

View file