ASoC: Fix mixed goto and guard() usage

Browse source

bui duc phuc <phucduc.bui@gmail.com> says:

These two patches fix the remaining cases of mixed goto-based error
handling and cleanup helpers introduced by the recent guard() conversion
patches that have already been merged for the 7.2 development cycle.

The cleanup.h guidelines explicitly recommend not mixing goto with
cleanup helpers in the same function. Only two functions were left in
this state:

 - sound/soc/samsung/i2s.c: remove the goto-based error path and rely
   on guard(pm_runtime) for automatic cleanup.
 - sound/soc/ti/j721e-evm.c: restore mutex_lock()/mutex_unlock() to
   preserve the existing goto-based error handling.

Although these cases do not trigger any build warnings or errors with
Clang (W=1), they still violate the cleanup.h guidelines. These
patches address those remaining cases and add the appropriate Fixes:
tags for the commits that introduced them.

Link: https://patch.msgid.link/20260701041310.230725-1-phucduc.bui@gmail.com

...

This commit is contained in:

Mark Brown 2026-07-01 16:34:51 +01:00

parent e3653722b9 47a0dde9a3

commit e487b00d70

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

2 changed files with 12 additions and 17 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

25

sound/soc/samsung/i2s.c

View file

4

sound/soc/ti/j721e-evm.c

View file