ASoC: Intel: sst-acpi: Request firmware before SST platform driver probing

Browse source

We originally thought to request SST audio DSP firmware during the SST
platform driver initialization. However plain request_firmware doesn't
work in driver probe paths if userspace is not ready to handle it. For
instance when drivers are built-in.

Implementing asynchronous firmware request in SST platform driver
initialization complicates code needlessly since it anyway will fail if
firmware is missing.

This is more simple to handle by requesting firmware asynchronously in
sst_acpi_probe() and register SST platform only after firmware is loaded.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Acked-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Signed-off-by: Mark Brown <broonie@linaro.org>

...

This commit is contained in:

Jarkko Nikula 2014-02-19 10:30:38 +02:00 • committed by Mark Brown

parent 0c49a8c9f9

commit e5161d7987

2 changed files with 40 additions and 18 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

56

sound/soc/intel/sst-acpi.c

View file

2

sound/soc/intel/sst-dsp.h

View file