net: ethernet: hisilicon: Convert to platform remove callback returning void

Browse source

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert these drivers from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Uwe Kleine-König 2023-09-18 22:41:54 +02:00 • committed by David S. Miller

parent dc715af33b

commit e5835a0a51

6 changed files with 12 additions and 22 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

6

drivers/net/ethernet/hisilicon/hip04_eth.c

View file

6

drivers/net/ethernet/hisilicon/hisi_femac.c

View file

6

drivers/net/ethernet/hisilicon/hix5hd2_gmac.c

View file

6

drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c

View file

5

drivers/net/ethernet/hisilicon/hns/hns_enet.c

View file

5

drivers/net/ethernet/hisilicon/hns_mdio.c

View file