net: qca_spi: Fix race condition in spi transfers

Browse source

With performance optimization the spi transfer and messages of basic
register operations like qcaspi_read_register moved into the private
driver structure. But they weren't protected against mutual access
(e.g. between driver kthread and ethtool). So dumping the QCA7000
registers via ethtool during network traffic could make spi_sync
hang forever, because the completion in spi_message is overwritten.

So revert the optimization completely.

Fixes: 291ab06ecf ("net: qualcomm: new Ethernet over SPI driver for QCA700")
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Stefan Wahren 2018-09-05 15:23:18 +02:00 • committed by David S. Miller

parent 9d7f19dc46

commit e65a9e480e

3 changed files with 93 additions and 98 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

76

drivers/net/ethernet/qualcomm/qca_7k.c

View file

112

drivers/net/ethernet/qualcomm/qca_spi.c

View file

5

drivers/net/ethernet/qualcomm/qca_spi.h

View file