bcachefs: Fix bch2_btree_node_iter_prev_filter()

Browse source

bch2_btree_node_iter_prev_filter() tried to be smart about iterating
backwards when skipping over whiteouts/discards - but unfortunately,
doing so can leave the node iterator in an inconsistent state; the sane
solution is to just always iterate backwards one key at a time.

But we compact btree nodes when more than a quarter of the keys are
whiteouts/discards, so the optimization wasn't buying us that much
anyways.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

...

This commit is contained in:

Kent Overstreet 2019-08-19 13:43:01 -04:00 • committed by Kent Overstreet

parent 9df279407a

commit e67ab0450c

2 changed files with 19 additions and 24 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

35

fs/bcachefs/bset.c

View file

8

fs/bcachefs/bset.h

View file