qlcnic: potential dereference null pointer of rx_queue->page_ring

Browse source

[ Upstream commit 60ec7fcfe7 ]

The return value of kcalloc() needs to be checked.
To avoid dereference of null pointer in case of the failure of alloc.
Therefore, it might be better to change the return type of
qlcnic_sriov_alloc_vlans() and return -ENOMEM when alloc fails and
return 0 the others.
Also, qlcnic_sriov_set_guest_vlan_mode() and __qlcnic_pci_sriov_enable()
should deal with the return value of qlcnic_sriov_alloc_vlans().

Fixes: 154d0c810c ("qlcnic: VLAN enhancement for 84XX adapters")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

...

This commit is contained in:

Jiasheng Jiang 2021-12-17 17:39:11 +08:00 • committed by Greg Kroah-Hartman

parent 5c553a0cd1

commit e69eacf74e

3 changed files with 13 additions and 5 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov.h

View file

12

drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c

View file

4

drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_pf.c

View file