kvm: x86: Convert return type of *is_valid_rdpmc_ecx() to bool

Browse source

These function names sound like predicates, and they have siblings,
*is_valid_msr(), which _are_ predicates. Moreover, there are comments
that essentially warn that these functions behave unexpectedly.

Flip the polarity of the return values, so that they become
predicates, and convert the boolean result to a success/failure code
at the outer call site.

Suggested-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Jim Mattson <jmattson@google.com>
Reviewed-by: Sean Christopherson <seanjc@google.com>
Message-Id: <20211105202058.1048757-1-jmattson@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

...

This commit is contained in:

Jim Mattson 2021-11-05 13:20:58 -07:00 • committed by Paolo Bonzini

parent 7e2175ebd6

commit e6cd31f1a8

5 changed files with 11 additions and 11 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

arch/x86/kvm/pmu.c

View file

4

arch/x86/kvm/pmu.h

View file

5

arch/x86/kvm/svm/pmu.c

View file

7

arch/x86/kvm/vmx/pmu_intel.c

View file

4

arch/x86/kvm/x86.c

View file