s390/qeth: detach netdevice while card is offline

Browse source

When a qeth card is offline, it has no connection to the HW. So none of
our control callbacks can run IO against it, and we can only cache the
input (eg a new MAC address) without providing proper feedback to the
caller. In this context, it seems much more reasonable to simply detach
the netdevice and let the kernel reject any interaction with it.

This also makes all sorts of internal state checks and locking obsolete.

Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Julian Wiedmann 2019-01-25 15:44:22 +01:00 • committed by David S. Miller

parent fa3d2e6059

commit e6e771b3d8

4 changed files with 20 additions and 102 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

5

drivers/s390/net/qeth_core.h

View file

51

drivers/s390/net/qeth_core_main.c

View file

47

drivers/s390/net/qeth_l2_main.c

View file

19

drivers/s390/net/qeth_l3_main.c

View file