powerpc/xmon: Add __printf annotation to xmon_printf()

Browse source

This allows the compiler to verify the format strings vs the types of
the arguments.

Update the other prototype declarations in asm/xmon.h.

Silence warnings (triggered at W=1) by adding relevant __printf
attribute. Move #define at bottom of the file to prevent conflict with
gcc attribute.

Solves the original warning:

  arch/powerpc/xmon/nonstdio.c:178:2: error: function might be
  possible candidate for ‘gnu_printf’ format attribute

In turn this uncovered many formatting errors in xmon.c, all fixed in
this patch.

Signed-off-by: Mathieu Malaterre <malat@debian.org>
[mpe: Always use px not p, fixup the 44x specific code, tweak change log]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

...

This commit is contained in:

Mathieu Malaterre 2018-03-25 11:06:47 +02:00 • committed by Michael Ellerman

parent 6671683db8

commit e70d8f5526

4 changed files with 75 additions and 75 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

arch/powerpc/include/asm/xmon.h

View file

8

arch/powerpc/xmon/nonstdio.h

View file

18

arch/powerpc/xmon/spu-dis.c

View file

122

arch/powerpc/xmon/xmon.c

View file