staging: tidspbridge: Remove cfg_get_dev_object() and do a trivial cleanup

Browse source

The cfg_get_dev_object function is only used in one place and because of
its simplicity, it can be removed.

The parameter *value can be left uninitialized if the strcmp() returns a
nonzero value, so in the function dev_remove_device(), the hdev_obj could
be used uninitialized and could be dereferenced in dev_destroy_device().
This patch fixes this issue, and also removes the dev_obj pointer which
is not used.

Signed-off-by: Ivan Gomez Castellanos <ivan.gomez@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

...

This commit is contained in:

Ivan Gomez Castellanos 2010-08-25 17:08:58 -05:00 • committed by Greg Kroah-Hartman

parent 345c8bec42

commit e8184e6c2d

3 changed files with 24 additions and 68 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

21

drivers/staging/tidspbridge/include/dspbridge/cfg.h

View file

30

drivers/staging/tidspbridge/pmgr/dev.c

View file

41

drivers/staging/tidspbridge/services/cfg.c

View file