USB: serial: ti_usb_3410_5052: fix array underflow in completion handler

Browse source

commit 5dfdd24eb3 upstream.

Similarly to a recently reported bug in io_ti, a malicious USB device
could set port_number to a negative value and we would underflow the
port array in the interrupt completion handler.

As these devices only have one or two ports, fix this by making sure we
only consider the seventh bit when determining the port number (and
ignore bits 0xb0 which are typically set to 0x30).

Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>

...

This commit is contained in:

Johan Hovold 2018-08-21 11:59:53 +02:00 • committed by Ben Hutchings

parent a0ebefb70b

commit e8ac3eaff7

1 changed files with 1 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/usb/serial/ti_usb_3410_5052.c

View file