Merge branch 'bpf: Add helpers to access traced function arguments'

Browse source

Jiri Olsa says:

====================
Add new helpers to access traced function arguments that
came out of the trampoline batch changes [1].

  Get n-th argument of the traced function:
    long bpf_get_func_arg(void *ctx, u32 n, u64 *value)

  Get return value of the traced function:
    long bpf_get_func_ret(void *ctx, u64 *value)

  Get arguments count of the traced funtion:
    long bpf_get_func_arg_cnt(void *ctx)

v2 changes:
  - added acks
  - updated stack diagram
  - return -EOPNOTSUPP instead of -EINVAL in bpf_get_func_ret
  - removed gpl_only for all helpers
  - added verifier fix to allow proper arguments checks,
    Andrii asked for checking also 'int *b' argument in
    bpf_modify_return_test programs and it turned out that it's currently
    not supported by verifier - we can't read argument that is int pointer,
    so I had to add verifier change to allow that + adding verifier selftest
  - checking all arguments in bpf_modify_return_test test programs
  - moved helpers proto gets in tracing_prog_func_proto with attach type check

thanks,
jirka

[1] https://lore.kernel.org/bpf/20211118112455.475349-1-jolsa@kernel.org/
====================

Signed-off-by: Alexei Starovoitov <ast@kernel.org>

...

This commit is contained in:

Alexei Starovoitov 2021-12-13 09:26:50 -08:00

parent 4b443bc178 006004b715

commit e94fac3829

11 changed files with 418 additions and 24 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

55

arch/x86/net/bpf_jit_comp.c

View file

5

include/linux/bpf.h

View file

28

include/uapi/linux/bpf.h

View file

7

kernel/bpf/btf.c

View file

8

kernel/bpf/trampoline.c

View file

77

kernel/bpf/verifier.c

View file

55

kernel/trace/bpf_trace.c

View file

28

tools/include/uapi/linux/bpf.h

View file

44

tools/testing/selftests/bpf/prog_tests/get_func_args_test.c

View file

123

tools/testing/selftests/bpf/progs/get_func_args_test.c

View file

12

tools/testing/selftests/bpf/verifier/btf_ctx_access.c

View file