xfs: uncached buffer reads need to return an error

Browse source

With verification being done as an IO completion callback, different
errors can be returned from a read. Uncached reads only return a
buffer or NULL on failure, which means the verification error cannot
be returned to the caller.

Split the error handling for these reads into two - a failure to get
a buffer will still return NULL, but a read error will return a
referenced buffer with b_error set rather than NULL. The caller is
responsible for checking the error state of the buffer returned.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Phil White <pwhite@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>

...

This commit is contained in:

Dave Chinner 2012-11-12 22:54:02 +11:00 • committed by Ben Myers

parent c3f8fc73ac

commit eab4e63368

4 changed files with 21 additions and 8 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

9

fs/xfs/xfs_buf.c

View file

5

fs/xfs/xfs_fsops.c

View file

6

fs/xfs/xfs_mount.c

View file

9

fs/xfs/xfs_rtalloc.c

View file