drm/amd/display: Switch ddc to new aux interface

Browse source

[Why]
The old aux interface goes through i2caux and the aux_engine
and engine function pointers.  The multiple layers of indirection
make it hard to tell waht is happening.  The aux algorithm
does not need to be this complicated: attempt to submit the
request.  If you get an ack (reply = 0), stop.  Otherwise,
retry, up to 7 times.

[How]
Add a new helper function in dce_aux that performs aux retries

Move the plumbing of the aux calling code into dce_aux

Add functions in ddc that redirect directly to dce_aux

Make all aux calls use these functions

Signed-off-by: David Francis <David.Francis@amd.com>
Reviewed-by: Harry Wentland <Harry.Wentland@amd.com>
Acked-by: Leo Li <sunpeng.li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

...

This commit is contained in:

David Francis 2018-11-29 14:36:25 -05:00 • committed by Alex Deucher

parent ad6756b4d7

commit eae5ffa9bd

4 changed files with 137 additions and 155 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

177

drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c

View file

99

drivers/gpu/drm/amd/display/dc/dce/dce_aux.c

View file

6

drivers/gpu/drm/amd/display/dc/dce/dce_aux.h

View file

12

drivers/gpu/drm/amd/display/dc/inc/dc_link_ddc.h

View file