drm/i915: Do not use ggtt_view with (aliasing) PPGTT

Browse source

GGTT views are only applicable when dealing with GGTT. Change the code to
reject ggtt_view where it should not be used and require it when it should
be.

v2:
- Dropped _ppgtt_ infixes, allow both types to be passed
- Disregard other but normal views when no view is specified
- More checks that valid parameters are passed
- More readable error checking

v3:
- Prefer WARN_ONCE over BUG_ON when there is code path for failure

Signed-off-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
[danvet: Drop unecessary forward decl from earlier patch iterations.]
[danvet: Remove unused variable spotted by Tvrtko.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

...

This commit is contained in:

Joonas Lahtinen 2015-03-16 14:11:13 +02:00 • committed by Daniel Vetter

parent aca5e361e8

commit ec7adb6ee7

3 changed files with 226 additions and 119 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

100

drivers/gpu/drm/i915/i915_drv.h

View file

174

drivers/gpu/drm/i915/i915_gem.c

View file

73

drivers/gpu/drm/i915/i915_gem_gtt.c

View file