drm/amd/display: on dp link lost event toggle dpms for master pipe only

Browse source

[why]
We mistakenly toggle dpms state for non master pipe when handling
link lost. A non master pipe doesn't connect to a backend. So it is
toggling dpms for non master is undefined and caused NULL pointer
dereference.

[how]
Add helper functions to find an array of active master pipes for current
link and only toggle DPMS for active master pipes connected to the link.
Add assert in case we get called to program dpms with non master pipe.

Reviewed-by: Alvin Lee <Alvin.Lee2@amd.com>
Acked-by: Qingqing Zhuo <qingqing.zhuo@amd.com>
Signed-off-by: Wenjing Liu <wenjing.liu@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

...

This commit is contained in:

Wenjing Liu 2023-01-27 19:16:05 -05:00 • committed by Alex Deucher

parent 3d8fcc6740

commit ed6941b632

5 changed files with 108 additions and 85 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

42

drivers/gpu/drm/amd/display/dc/link/accessories/link_dp_cts.c

View file

31

drivers/gpu/drm/amd/display/dc/link/link_detection.c

View file

69

drivers/gpu/drm/amd/display/dc/link/link_dpms.c

View file

5

drivers/gpu/drm/amd/display/dc/link/link_dpms.h

View file

46

drivers/gpu/drm/amd/display/dc/link/protocols/link_dp_irq_handler.c

View file