libata/pdc_adma: make SFF EH handle non-bmdma SFF drivers and standardize pdc_adma ops

Browse source

pdc_adma has interface similar to SFF but has its own DMA interface.
It currently implements noop bmdma ops to avoid crashing
ata_bmdma_error_handler() which BTW actually is EH for SFF drivers.

This patch makes ata_bmdma_error_handler() dereference bmdma ops iff
bmdma_addr is initialized as done in ata_bmdma_post_internal_cmd.
This change allows pdc_adma to standardize ops and use SFF
error_handler and post_internal_cmd.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Mark Lord <liml@rtr.ca>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

...

This commit is contained in:

Tejun Heo 2008-03-25 21:34:39 +09:00 • committed by Jeff Garzik

parent d8b81b8008

commit ed82f96425

2 changed files with 4 additions and 15 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

drivers/ata/libata-sff.c

View file

16

drivers/ata/pdc_adma.c

View file