net: ethernet: mtk_eth_soc: fix return values and refactor MDIO ops

Browse source

Instead of returning -1 (-EPERM) when MDIO bus is stuck busy
while writing or 0xffff if it happens while reading, return the
appropriate -ETIMEDOUT. Also fix return type to int instead of u32.
Refactor functions to use bitfield helpers instead of having various
masking and shifting constants in the code, which also results in the
register definitions in the header file being more obviously related
to what is stated in the MediaTek's Reference Manual.

Fixes: 656e705243 ("net-next: mediatek: add support for MT7623 ethernet")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Daniel Golle 2022-01-04 12:06:22 +00:00 • committed by David S. Miller

parent ffd32ea6b1

commit eda80b249d

2 changed files with 41 additions and 28 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

53

drivers/net/ethernet/mediatek/mtk_eth_soc.c

View file

16

drivers/net/ethernet/mediatek/mtk_eth_soc.h

View file