powerpc/pseries: Check for GIQ indicator before calling set-indicator

Browse source

Since "Factor out cpu joining/unjoining the GIQ"
(b4963255ad) the WARN_ON in
xics_set_cpu_giq() is being triggered during boot on JS20 because the
GIQ indicator is not available on that platform.  While the warning is
harmless and the system runs normally, it's nicer to check for the
existence of the indicator before trying to manipulate it.

Implement rtas_indicator_present(), which searches the
/rtas/rtas-indicators property for the given indicator token, and use
this function in xics_set_cpu_giq().

Also use a WARN statement in xics_set_cpu_giq to get better
information on failure.

Signed-off-by: Nathan Lynch <ntl@pobox.com>
Acked-by: Milton Miller <miltonm@bga.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>

...

This commit is contained in:

Nathan Lynch 2008-12-11 09:14:25 +00:00 • committed by Paul Mackerras

parent 6ff04c53db

commit edc72ac4a0

3 changed files with 39 additions and 3 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

arch/powerpc/include/asm/rtas.h

View file

26

arch/powerpc/kernel/rtas.c

View file

15

arch/powerpc/platforms/pseries/xics.c

View file