xprtrdma: Fix cwnd update ordering

Browse source

[ Upstream commit 35d8b10a25 ]

After a reconnect, the reply handler is opening the cwnd (and thus
enabling more RPC Calls to be sent) /before/ rpcrdma_post_recvs()
can post enough Receive WRs to receive their replies. This causes an
RNR and the new connection is lost immediately.

The race is most clearly exposed when KASAN and disconnect injection
are enabled. This slows down rpcrdma_rep_create() enough to allow
the send side to post a bunch of RPC Calls before the Receive
completion handler can invoke ib_post_recv().

Fixes: 2ae50ad68c ("xprtrdma: Close window between waking RPC senders and posting Receives")
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

...

This commit is contained in:

Chuck Lever 2021-04-19 14:02:41 -04:00 • committed by Greg Kroah-Hartman

parent 89a31bf85c

commit eddae8be79

3 changed files with 8 additions and 7 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

3

net/sunrpc/xprtrdma/rpc_rdma.c

View file

10

net/sunrpc/xprtrdma/verbs.c

View file

2

net/sunrpc/xprtrdma/xprt_rdma.h

View file