net: mctp: avoid confusion over local/peer dest/source addresses

Browse source

We have a double-swap of local and peer addresses in
mctp_alloc_local_tag; the arguments in both call sites are swapped, but
there is also a swap in the implementation of alloc_local_tag. This is
opaque because we're using source/dest address references, which don't
match the local/peer semantics.

Avoid this confusion by naming the arguments as 'local' and 'peer', and
remove the double swap. The calling order now matches mctp_key_alloc.

Signed-off-by: Jeremy Kerr <jk@codeconstruct.com.au>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

...

This commit is contained in:

Jeremy Kerr 2024-02-19 17:51:46 +08:00 • committed by Paolo Abeni

parent 6d5c36565c

commit ee076b73e5

3 changed files with 11 additions and 11 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

include/net/mctp.h

View file

2

net/mctp/af_mctp.c

View file

16

net/mctp/route.c

View file