selftests/bpf: Add __noinline variant of cls_redirect selftest

Browse source

As one of the most complicated and close-to-real-world programs, cls_redirect
is a good candidate to exercise libbpf's logic of handling bpf2bpf calls. So
add variant with using explicit __noinline for majority of functions except
few most basic ones. If those few functions are inlined, verifier starts to
complain about program instruction limit of 1mln instructions being exceeded,
most probably due to instruction overhead of doing a sub-program call.
Convert user-space part of selftest to have to sub-tests: with and without
inlining.

Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Cc: Lorenz Bauer <lmb@cloudflare.com>
Link: https://lore.kernel.org/bpf/20200903203542.15944-15-andriin@fb.com

...

This commit is contained in:

Andrii Nakryiko 2020-09-03 13:35:42 -07:00 • committed by Alexei Starovoitov

parent baaf680e08

commit ee333df50b

3 changed files with 115 additions and 64 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

72

tools/testing/selftests/bpf/prog_tests/cls_redirect.c

View file

103

tools/testing/selftests/bpf/progs/test_cls_redirect.c

View file

2

tools/testing/selftests/bpf/progs/test_cls_redirect_subprogs.c

View file