RDMA/irdma: Add missing read barriers

Browse source

[ Upstream commit 4984eb5145 ]

On code inspection, there are many instances in the driver where
CEQE and AEQE fields written to by HW are read without guaranteeing
that the polarity bit has been read and checked first.

Add a read barrier to avoid reordering of loads on the CEQE/AEQE fields
prior to checking the polarity bit.

Fixes: 3f49d68425 ("RDMA/irdma: Implement HW Admin Queue OPs")
Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
Link: https://lore.kernel.org/r/20230711175253.1289-2-shiraz.saleem@intel.com
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

...

This commit is contained in:

Shiraz Saleem 2023-07-11 12:52:51 -05:00 • committed by Greg Kroah-Hartman

parent 0370fbed4d

commit ee38994979

3 changed files with 17 additions and 1 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

9

drivers/infiniband/hw/irdma/ctrl.c

View file

6

drivers/infiniband/hw/irdma/puda.c

View file

3

drivers/infiniband/hw/irdma/uk.c

View file