xfs: remove the ->data_unused_p method

Browse source

Replace the two users of the ->data_unused_p dir ops method with a
direct calculation using ->data_entry_offset, and clean them up a bit.
xfs_dir2_sf_to_block already had an offset variable containing the
value of ->data_entry_offset, which we are now reusing to make it
clear that the initial freespace entry is at the same place that
we later fill in the 1 entry, and in xfs_dir3_data_init the function
is cleaned up a bit to keep the initialization of fields of a given
structure close to each other, and to avoid a local variable.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

...

This commit is contained in:

Christoph Hellwig 2019-11-08 15:05:31 -08:00 • committed by Darrick J. Wong

parent da3ca0df8b

commit ee641d5af5

4 changed files with 19 additions and 42 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

17

fs/xfs/libxfs/xfs_da_format.c

View file

2

fs/xfs/libxfs/xfs_dir2.h

View file

2

fs/xfs/libxfs/xfs_dir2_block.c

View file

38

fs/xfs/libxfs/xfs_dir2_data.c

View file