Orangefs: address problems found by static checker

Browse source

Don't check for negative rc from boolean.

  Don't pointlessly initialize variables, it short-circuits
  gcc's uninitialized variable warnings. And max_new_nr_segs
  can never be zero, so don't check for it.

  Preserve original kstrdup pointer for freeing later.

  Don't check for negative value in unsigned variable.

Signed-off-by: Mike Marshall <hubcap@omnibond.com>

...

This commit is contained in:

Mike Marshall 2015-07-29 13:36:37 -04:00

parent 84d02150de

commit eeaa3d448c

4 changed files with 11 additions and 33 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

16

fs/orangefs/dir.c

View file

18

fs/orangefs/file.c

View file

4

fs/orangefs/pvfs2-utils.c

View file

6

fs/orangefs/xattr.c

View file