ISDN: eicon: switch to use native bitmaps

Browse source

Two arrays are clearly bit maps, so, make that explicit by converting to
bitmap API and remove custom helpers.

Note sig_ind() uses out of boundary bit to (looks like) protect against
potential bitmap_empty() checks for the same bitmap.

This patch removes that since:
1) that didn't guarantee atomicity anyway;
2) the first operation inside the for-loop is set bit in the bitmap
   (which effectively makes it non-empty);
3) group_optimization() doesn't utilize possible emptiness of the bitmap
   in question.

Thus, if there is a protection needed it should be implemented properly.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Andy Shevchenko 2017-07-18 18:49:26 +03:00 • committed by David S. Miller

parent 9b17010da5

commit eeef1713ca

2 changed files with 58 additions and 205 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

16

drivers/isdn/hardware/eicon/divacapi.h

View file

247

drivers/isdn/hardware/eicon/message.c

View file