KVM: selftests: Consolidate boilerplate code in get_ucall()

Browse source

Consolidate the actual copying of a ucall struct from guest=>host into
the common get_ucall().  Return a host virtual address instead of a guest
virtual address even though the addr_gva2hva() part could be moved to
get_ucall() too.  Conceptually, get_ucall() is invoked from the host and
should return a host virtual address (and returning NULL for "nothing to
see here" is far superior to returning 0).

Use pointer shenanigans instead of an unnecessary bounce buffer when the
caller of get_ucall() provides a valid pointer.

Reviewed-by: Andrew Jones <andrew.jones@linux.dev>
Tested-by: Peter Gonda <pgonda@google.com>
Signed-off-by: Sean Christopherson <seanjc@google.com>
Link: https://lore.kernel.org/r/20221006003409.649993-3-seanjc@google.com

...

This commit is contained in:

Sean Christopherson 2022-10-06 00:34:04 +00:00

parent 7046638192

commit ef38871eb2

6 changed files with 33 additions and 59 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

8

tools/testing/selftests/kvm/include/ucall_common.h

View file

14

tools/testing/selftests/kvm/lib/aarch64/ucall.c

View file

19

tools/testing/selftests/kvm/lib/riscv/ucall.c

View file

16

tools/testing/selftests/kvm/lib/s390x/ucall.c

View file

19

tools/testing/selftests/kvm/lib/ucall_common.c

View file

16

tools/testing/selftests/kvm/lib/x86_64/ucall.c

View file