cifs: remove useless parameter 'is_fsctl' from SMB2_ioctl()

Browse source

[ Upstream commit 400d0ad63b ]

SMB2_ioctl() is always called with is_fsctl = true, so doesn't make any
sense to have it at all.

Thus, always set SMB2_0_IOCTL_IS_FSCTL flag on the request.

Also, as per MS-SMB2 3.3.5.15 "Receiving an SMB2 IOCTL Request", servers
must fail the request if the request flags is zero anyway.

Signed-off-by: Enzo Matsumiya <ematsumiya@suse.de>
Reviewed-by: Tom Talpey <tom@talpey.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

...

This commit is contained in:

Enzo Matsumiya 2022-08-17 16:08:34 -03:00 • committed by Greg Kroah-Hartman

parent c0deb027c9

commit ef69b108b5

4 changed files with 24 additions and 36 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

1

fs/cifs/smb2file.c

View file

35

fs/cifs/smb2ops.c

View file

20

fs/cifs/smb2pdu.c

View file

4

fs/cifs/smb2proto.h

View file