xfs: attr fork iext must be loaded before calling xfs_attr_is_leaf

Browse source

Christoph noticed that the xfs_attr_is_leaf in xfs_attr_get_ilocked can
access the incore extent tree of the attr fork, but nothing in the
xfs_attr_get path guarantees that the incore tree is actually loaded.

Most of the time it is, but seeing as xfs_attr_is_leaf ignores the
return value of xfs_iext_get_extent I guess we've been making choices
based on random stack contents and nobody's complained?

Reported-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>

...

This commit is contained in:

Darrick J. Wong 2024-04-22 09:47:24 -07:00

parent cda60317ac

commit ef80de940a

3 changed files with 60 additions and 6 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

17

fs/xfs/libxfs/xfs_attr.c

View file

42

fs/xfs/xfs_attr_item.c

View file

7

fs/xfs/xfs_attr_list.c

View file