sk98lin: kill bogus check and convert to use ARRAY_SIZE()

Browse source

This converts uses of ARRAY_SIZE(), and while at it also kills
unreachable code as far as I can say. I can't tell what was the author
trying to do with the following check. First we have:

PNMI_STATIC const SK_PNMI_STATADDR
		StatAddr[SK_PNMI_MAX_IDX][SK_PNMI_MAC_TYPES];

and then a check goes like this:

if (SK_PNMI_MAX_IDX !=
   (sizeof(StatAddr) / (sizeof(SK_PNMI_STATADDR) * SK_PNMI_MAC_TYPES)))

with the second line being just ARRAY_SIZE(StatAddr), which will always
return SK_PNMI_MAX_IDX, rendering the check useless.

Signed-off-by: Alejandro Martinez Ruiz <alex@flawedcode.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

...

This commit is contained in:

Alejandro Martinez Ruiz 2007-10-18 10:22:02 +02:00 • committed by David S. Miller

parent c00acf46de

commit ef878b8899

3 changed files with 2 additions and 14 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/net/sk98lin/skgemib.c

View file

12

drivers/net/sk98lin/skgepnmi.c

View file

2

drivers/net/sk98lin/skgesirq.c

View file