media: platform: mtk-mdp3: fix error handling about components clock_on

Browse source

[ Upstream commit 74a596e7fc ]

Add goto statement in mdp_comp_clock_on() to avoid error code not being
propagated or returning positive values.
This change also performs a well-timed clock_off when an error occurs, and
reduces unnecessary error logging in mdp_cmdq_send().

Fixes: 61890ccaef ("media: platform: mtk-mdp3: add MediaTek MDP3 driver")
Signed-off-by: Moudy Ho <moudy.ho@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Sasha Levin <sashal@kernel.org>

...

This commit is contained in:

Moudy Ho 2022-10-20 15:17:59 +08:00 • committed by Greg Kroah-Hartman

parent ab49175a5a

commit ef9170c00e

2 changed files with 19 additions and 9 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

4

drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c

View file

24

drivers/media/platform/mediatek/mdp3/mtk-mdp3-comp.c

View file