drm/omap: cleanup fbdev init/free

Browse source

omap_fbdev_init() and omap_fbdev_free() use priv->fbdev directly.
However, omap_fbdev_init() returns the fbdev, and omap_drv.c also
assigns the return value to priv->fbdev. This is slightly confusing.

Clean this up by removing the omap_fbdev_init() return value, as we
don't care whether fbdev init succeeded or not. Also change omap_drv.c
to call omap_fbdev_free() always, and omap_fbdev_free() does the check
if fbdev was initialized.

While at it, rename omap_fbdev_free() to omap_fbdev_fini() to better
match the "init" counterpart.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

...

This commit is contained in:

Tomi Valkeinen 2018-02-09 09:36:23 +02:00

parent e6204a58b9

commit efd1f06be0

3 changed files with 16 additions and 20 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

9

drivers/gpu/drm/omapdrm/omap_drv.c

View file

18

drivers/gpu/drm/omapdrm/omap_fbdev.c

View file

9

drivers/gpu/drm/omapdrm/omap_fbdev.h

View file