ASoC: rt5651: Move all jack-detect initialization to rt5651_set_jack_detect

Browse source

Move all jack-detect initialization to rt5651_set_jack_detect. The main
reason to do this is so that platform code can setup jack-detect properties
after the device has been probed, which unfortunately is necessary on some
platforms.

This has 2 additional advantages:
1) Grouping all jack-detect init together makes it easier to follow what
is happening and results in a small reduction in the number of loc.
2) Before we would register the irq handler before rt5651->hp_jack was
assigned, leading to a potential NULL deref if the jack_detect work runs
before the machine driver has called set_jack.

Tested-by: Carlo Caione <carlo@endlessm.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

...

This commit is contained in:

Hans de Goede 2018-02-25 11:46:43 +01:00 • committed by Mark Brown

parent 54e3a3a152

commit f06da4fdb5

No known key found for this signature in database

GPG key ID: 24D68B725D5487D0

2 changed files with 58 additions and 62 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

119

sound/soc/codecs/rt5651.c

View file

1

sound/soc/codecs/rt5651.h

View file