[media] uvcvideo: Set error_idx properly for extended controls API failures

Browse source

When one of the requested controls doesn't exist the error_idx field
must reflect that situation. For G_EXT_CTRLS and S_EXT_CTRLS, error_idx
must be set to the control count. For TRY_EXT_CTRLS, it must be set to
the index of the unexisting control.
This issue was found by the v4l2-compliance tool.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

...

This commit is contained in:

Laurent Pinchart 2012-08-28 18:38:58 -03:00 • committed by Mauro Carvalho Chehab

parent e9de051666

commit f0ed2ce840

2 changed files with 22 additions and 14 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

17

drivers/media/usb/uvc/uvc_ctrl.c

View file

19

drivers/media/usb/uvc/uvc_v4l2.c

View file