PCI: PCIe portdrv: Do not enable port device before setting up interrupts

Browse source

The PCI Express port driver calls pci_enable_device() before setting
up interrupts, which is wrong, because if there is an interrupt pin
configured for the port, pci_enable_device() will likely set up an
interrupt link for it.  However, this shouldn't be done if either
MSI or MSI-X interrupt mode is chosen for the port.

The solution is to call pci_enable_device() after setting up
interrupts, because in that case the interrupt link won't be set up
if MSI or MSI-X are enabled.

Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

...

This commit is contained in:

Rafael J. Wysocki 2009-01-13 14:42:01 +01:00 • committed by Jesse Barnes

parent 90e9cd50f7

commit f118c0c3cf

2 changed files with 31 additions and 18 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

44

drivers/pci/pcie/portdrv_core.c

View file

11

drivers/pci/pcie/portdrv_pci.c

View file