rtl8188eu: pwrctrl_priv: Replace semaphore 'lock' with mutex

Browse source

The semaphore 'lock' in pwrctrl_priv is a simple mutex, so it should
be written as one. Semaphores are going away in the future.
_enter_pwrlock was using down_interruptible(), so the lock could be broken
by sending a signal. This could be a bug, because nothing checks the return
code here. Hence, using mutex_lock instead of the interruptible version.
Also, remove the now unused wrappers _init_pwrlock, _enter_pwrlock,
_exit_pwrlock and _rtw_down_sema.

Signed-off-by: Binoy Jayan <binoy.jayan@linaro.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

...

This commit is contained in:

Binoy Jayan 2016-06-06 10:08:06 +05:30 • committed by Greg Kroah-Hartman

parent 16677cca77

commit f18c566e4e

6 changed files with 17 additions and 39 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

20

drivers/staging/rtl8188eu/core/rtw_pwrctrl.c

View file

3

drivers/staging/rtl8188eu/include/osdep_service.h

View file

1

drivers/staging/rtl8188eu/include/rtw_event.h

View file

17

drivers/staging/rtl8188eu/include/rtw_pwrctrl.h

View file

7

drivers/staging/rtl8188eu/os_dep/osdep_service.c

View file

8

drivers/staging/rtl8188eu/os_dep/usb_intf.c

View file