drm/imagination: Fixed oops when misusing ioctl CREATE_HWRT_DATASET

Browse source

While writing the matching IGT suite I discovered that it's possible to
cause a kernel oops when using DRM_IOCTL_PVR_CREATE_HWRT_DATASET when
the call to hwrt_init_common_fw_structure() fails.

Use an unwind-type error path to avoid cleaning up the object using the
the release function before it is fully resolved.

Signed-off-by: Donald Robson <donald.robson@imgtec.com>
Signed-off-by: Maxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20231208163019.95913-1-donald.robson@imgtec.com

...

This commit is contained in:

Donald Robson 2023-12-08 16:30:19 +00:00 • committed by Maxime Ripard

parent b39610c773

commit f1f55ed3ff

No known key found for this signature in database

GPG key ID: E3EF0D6F671851C5

1 changed files with 14 additions and 13 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

27

drivers/gpu/drm/imagination/pvr_hwrt.c

View file