scsi: qla2xxx: Move debug messages before sending srb preventing panic

Browse source

When sending an srb with qla2x00_start_sp, the sp can complete and be freed
by the time we log the debug message saying we sent it. This can cause a
panic if sp gets reused quickly or when running a kernel that poisons freed
memory.

This was partially fixed by (not every case was addressed):

Commit 9fe278f44b ("scsi: qla2xxx: Move log messages before issuing
command to firmware")

Signed-off-by: Bill Kuzeja <william.kuzeja@stratus.com>
Acked-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

...

This commit is contained in:

Bill Kuzeja 2019-02-14 10:52:29 -05:00 • committed by Martin K. Petersen

parent 59e54d9aab

commit f233e8c000

3 changed files with 55 additions and 45 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

66

drivers/scsi/qla2xxx/qla_gs.c

View file

26

drivers/scsi/qla2xxx/qla_init.c

View file

8

drivers/scsi/qla2xxx/qla_target.c

View file