x86: Replace NSC/Cyrix specific chipset access macros by inlined functions.

Browse source

Due to index register access ordering problems, when using macros a line
like this fails (and does nothing):

	setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x88);

With inlined functions this line will work as expected.

Note about a side effect: Seems on Geode GX1 based systems the
"suspend on halt power saving feature" was never enabled due to this
wrong macro expansion. With inlined functions it will be enabled, but
this will stop the TSC when the CPU runs into a HLT instruction.
Kernel output something like this:
	Clocksource tsc unstable (delta = -472746897 ns)

This is the 3rd version of this patch.

 - Adding missed arch/i386/kernel/cpu/mtrr/state.c
	Thanks to Andres Salomon
 - Adding some big fat comments into the new header file
 	Suggested by Andi Kleen

AK: fixed x86-64 compilation

Signed-off-by: Juergen Beisert <juergen@kreuzholzen.de>
Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

...

This commit is contained in:

Juergen Beisert 2007-07-22 11:12:38 +02:00 • committed by Linus Torvalds

parent bdda1561ff

commit f25f64ed5b

7 changed files with 34 additions and 24 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

arch/i386/kernel/cpu/cpufreq/gx-suspmod.c

View file

2

arch/i386/kernel/cpu/cyrix.c

View file

1

arch/i386/kernel/cpu/mtrr/cyrix.c

View file

1

arch/i386/kernel/cpu/mtrr/state.c

View file