media: atomisp: Add atomisp_pipe_check() helper

Browse source

Several of the ioctl handlers all do the same checks
(isp->fatal_error and asd->streaming errors) add
an atomisp_pipe_check() helper for this.

Note this changes the vidioc_s_fmt_vid_cap and vidioc_s_input handlers
to now reject calls made while asd->streaming==STOPPING. This fixes
a possible race where one thread can make this ioctls while
vidioc_streamoff is running from another thread and it has
temporarily released isp->mutex to kill the watchdog timers / work.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>

...

This commit is contained in:

Hans de Goede 2022-09-03 14:49:39 +02:00 • committed by Mauro Carvalho Chehab

parent 0d51573df3

commit f315c1acba

3 changed files with 48 additions and 52 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

9

drivers/staging/media/atomisp/pci/atomisp_cmd.c

View file

89

drivers/staging/media/atomisp/pci/atomisp_ioctl.c

View file

2

drivers/staging/media/atomisp/pci/atomisp_ioctl.h

View file