Merge branch 'net-macsec-remove-the-preparation-phase-when-offloading-operations'

Browse source

Antoine Tenart says:

====================
net: macsec: remove the preparation phase when offloading operations

It was reported[1] the 2-step phase offloading of MACsec operations did
not fit well and device drivers were mostly ignoring the first phase
(preparation). In addition the s/w fallback in case h/w rejected an
operation, which could have taken advantage of this design, never was
implemented and it's probably not a good idea anyway (at least
unconditionnally). So let's remove this logic which only makes the code
more complex for no advantage, before there are too many drivers
providing MACsec offloading.

This series removes the first phase (preparation) of the MACsec h/w
offloading. The modifications are split per-driver and in a way that
makes bissection working with logical steps; but I can squash some
patches if needed.

This was tested on the MSCC PHY but not on the Altantic nor mlx5e NICs.

[1] https://lore.kernel.org/all/166322893264.61080.12133865599607623050@kwain/T/
====================

Link: https://lore.kernel.org/r/20220921135118.968595-1-atenart@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

...

This commit is contained in:

Jakub Kicinski 2022-09-23 06:56:12 -07:00

parent aacdecda9e 99383f1298

commit f416bdfb6a

5 changed files with 39 additions and 183 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

57

drivers/net/ethernet/aquantia/atlantic/aq_macsec.c

View file

36

drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c

View file

14

drivers/net/macsec.c

View file

113

drivers/net/phy/mscc/mscc_macsec.c

View file

2

include/net/macsec.h

View file