bcachefs: bch2_disk_accounting_mod2()

Browse source

We're hitting some issues with uninitialized struct padding, flagged by
kmsan.

They appear to be falso positives, otherwise bch2_accounting_validate()
would have flagged them as "junk at end". But for now, we'll need to
initialize disk_accounting_pos with memset().

This adds a new helper, bch2_disk_accounting_mod2(), that initializes a
disk_accounting_pos and does the accounting mod all at once - so overall
things actually get slightly more ergonomic.

BCH_DISK_ACCOUNTING_replicas keys are left for now; KMSAN isn't warning
about them and they're a bit special.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>

...

This commit is contained in:

Kent Overstreet 2025-03-21 12:29:56 -04:00

parent 5ae6f33053

commit f4a584f4bf

6 changed files with 57 additions and 65 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

10

fs/bcachefs/alloc_background.c

View file

66

fs/bcachefs/buckets.c

View file

18

fs/bcachefs/disk_accounting.h

View file

12

fs/bcachefs/disk_accounting_format.h

View file

7

fs/bcachefs/inode.c

View file

9

fs/bcachefs/super.c

View file