mlxsw: core: Use devm_kzalloc to allocate mlxsw_hwmon structure

Browse source

KASan reported use-after-free for the hwmon structure. So fix this by
using devm_kzalloc and let the core take care about freeing the memory
during device dettach.

Reported-by: Ido Schimmel <idosch@mellanox.com>
Fixes: 89309da39 ("mlxsw: core: Implement temperature hwmon interface")
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

Jiri Pirko 2015-12-22 09:43:07 +01:00 • committed by David S. Miller

parent 2010b93e93

commit f4cee3af0d

3 changed files with 2 additions and 13 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/net/ethernet/mellanox/mlxsw/core.c

View file

4

drivers/net/ethernet/mellanox/mlxsw/core.h

View file

9

drivers/net/ethernet/mellanox/mlxsw/core_hwmon.c

View file