xfs: mark inode buffers in cache

Browse source

Inode buffers always have write IO callbacks, so by marking them
directly we can avoid needing to attach ->b_iodone functions to
them. This avoids an indirect call, and makes future modifications
much simpler.

While this is largely a refactor of existing functionality, we
broaden the scope of the flag to beyond where inodes are explicitly
attached because future changes need to know what type of log items
are attached to the buffer. Adding this buffer flag may invoke the
inode iodone callback in cases where it wouldn't have been
previously, but this is not a functional change because the callback
is identical to the normal buffer write iodone callback when inodes
are not attached.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

...

This commit is contained in:

Dave Chinner 2020-06-29 14:48:46 -07:00 • committed by Darrick J. Wong

parent 1319ebefd6

commit f593bf144c

6 changed files with 77 additions and 30 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

21

fs/xfs/xfs_buf.c

View file

38

fs/xfs/xfs_buf.h

View file

42

fs/xfs/xfs_buf_item.c

View file

1

fs/xfs/xfs_buf_item.h

View file

2

fs/xfs/xfs_inode.c

View file

3

fs/xfs/xfs_trans_buf.c

View file