Merge branch 'net-sched-init-failure-fixes'

Browse source

Nikolay Aleksandrov says:

====================
net/sched: init failure fixes

I went over all qdiscs' init, destroy and reset callbacks and found the
issues fixed in each patch. Mostly they are null pointer dereferences due
to uninitialized timer (qdisc watchdog) or double frees due to ->destroy
cleaning up a second time. There's more information in each patch.
I've tested these by either sending wrong attributes from user-spaces, no
attributes or by simulating memory alloc failure where applicable. Also
tried all of the qdiscs as a default qdisc.

Most of these bugs were present before commit 87b60cfacf, I've tried to
include proper fixes tags in each patch.

I haven't included individual patch acks in the set, I'd appreciate it if
you take another look and resend them.
====================

Acked-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

...

This commit is contained in:

David S. Miller 2017-08-30 15:26:12 -07:00

parent f0e82d737d c2d6511e6a

commit f5c3dd4b53

9 changed files with 26 additions and 28 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

10

net/sched/sch_cbq.c

View file

4

net/sched/sch_fq_codel.c

View file

10

net/sched/sch_hfsc.c

View file

3

net/sched/sch_hhf.c

View file

5

net/sched/sch_htb.c

View file

7

net/sched/sch_multiq.c

View file

4

net/sched/sch_netem.c

View file

6

net/sched/sch_sfq.c

View file

5

net/sched/sch_tbf.c

View file