ksmbd: fix racy issue from session setup and logoff

Browse source

This racy issue is triggered by sending concurrent session setup and
logoff requests. This patch does not set connection status as
KSMBD_SESS_GOOD if state is KSMBD_SESS_NEED_RECONNECT in session setup.
And relookup session to validate if session is deleted in logoff.

Cc: stable@vger.kernel.org
Reported-by: zdi-disclosures@trendmicro.com # ZDI-CAN-20481, ZDI-CAN-20590, ZDI-CAN-20596
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>

...

This commit is contained in:

Namjae Jeon 2023-05-03 16:45:00 +09:00 • committed by Steve French

parent 3ac00a2ab6

commit f5c779b7dd

6 changed files with 77 additions and 49 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

14

fs/ksmbd/connection.c

View file

39

fs/ksmbd/connection.h

View file

1

fs/ksmbd/mgmt/user_session.c

View file

3

fs/ksmbd/server.c

View file

67

fs/ksmbd/smb2pdu.c

View file

2

fs/ksmbd/transport_tcp.c

View file