xfs: fix broken bhold behavior in xrep_roll_ag_trans

Browse source

In xrep_roll_ag_trans, the transaction roll will always set sc->tp to
the new transaction, even if committing the old one fails.  A bare
transaction roll leaves the buffer(s) locked but not joined to the new
transaction, so it's not necessary to release the hold if the roll
fails.  Remove the incorrect xfs_trans_bhold_release calls.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>

...

This commit is contained in:

Darrick J. Wong 2019-04-24 10:39:49 -07:00

parent 3de5eab3fd

commit f60be90fc9

1 changed files with 8 additions and 17 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

25

fs/xfs/scrub/repair.c

View file