drm/vmwgfx: Introduce a new placement for MOB page tables

Browse source

For larger (bigger than a page) and noncontiguous mobs we have
to create page tables that allow the host to find the memory.
Those page tables just used regular system memory. Unfortunately
in TTM those BO's are not allowed to be busy thus can't be
fenced and we have to fence those bo's  because we don't want
to destroy the page tables while the host is still executing
the command buffers which might be accessing them.

To solve it we introduce a new placement VMW_PL_SYSTEM which
is very similar to TTM_PL_SYSTEM except that it allows
fencing. This fixes kernel oops'es during unloading of the driver
(and pci hot remove/add) which were caused by busy BO's in
TTM_PL_SYSTEM being present in the delayed deletion list in
TTM (TTM_PL_SYSTEM manager is destroyed before the delayed
deletions are executed)

Signed-off-by: Zack Rusin <zackr@vmware.com>
Reviewed-by: Martin Krastev <krastevm@vmware.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211105193845.258816-5-zackr@vmware.com

...

This commit is contained in:

Zack Rusin 2021-11-05 15:38:45 -04:00

parent c451af78f3

commit f6be23264b

5 changed files with 138 additions and 38 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download patch file Download diff file Expand all files Collapse all files

2

drivers/gpu/drm/vmwgfx/Makefile

View file

14

drivers/gpu/drm/vmwgfx/vmwgfx_drv.c

View file

12

drivers/gpu/drm/vmwgfx/vmwgfx_drv.h

View file

90

drivers/gpu/drm/vmwgfx/vmwgfx_system_manager.c

View file

58

drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c

View file